Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.x] Introduce tests for add new visualization link #10853

Closed
wants to merge 1 commit into from
Closed

[5.x] Introduce tests for add new visualization link #10853

wants to merge 1 commit into from

Conversation

elastic-jasper
Copy link
Contributor

Introduce tests for add new visualization link

Backports PR #10785

Commit 1:
Introduce tests for add new visualization link

Commit 2:
address code review comment

@elastic-jasper
Introduce tests for add new visualization link
5814f83 
Backports PR #10785

**Commit 1:**
Introduce tests for add new visualization link

* Original sha: ddf8288
* Authored by Stacey Gammon <[email protected]> on 2017-03-17T16:45:24Z

**Commit 2:**
address code review comment

* Original sha: b4709dc
* Authored by Stacey Gammon <[email protected]> on 2017-03-22T19:37:02Z
@stacey-gammon
Copy link
Contributor

stacey-gammon commented Mar 23, 2017 •
edited
Loading

Looks like 5.x still has some no-unused-var errors. Backporting #10859 should fix it.

Running "eslint:source" (eslint) task

/var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-intake/test/functional/apps/management/_index_pattern_filter.js
   6:3   error  'defaultTimeout' is defined but never used             no-unused-vars
   7:3   error  'scenarioManager' is defined but never used            no-unused-vars
  36:11  error  'fieldTypesBefore' is assigned a value but never used  no-unused-vars

/var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-intake/test/functional/apps/management/_scripted_fields_filter.js
  6:3  error  'scenarioManager' is defined but never used  no-unused-vars

✖ 4 problems (4 errors, 0 warnings)

@stacey-gammon
Copy link
Contributor

Closing in favor of #10869 so I can rebase

@epixa epixa deleted the jasper/backport/10785/5.x branch March 23, 2017 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@stacey-gammon stacey-gammon

Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elastic-jasper @stacey-gammon